Use 6.1 guest kernel configs from AL #4746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4746 +/- ##
=======================================
Coverage 84.34% 84.34%
=======================================
Files 249 249
Lines 27461 27461
=======================================
Hits 23162 23162
Misses 4299 4299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bchalios
force-pushed
the
make-guest-config-patches
branch
3 times, most recently
from
cf0cd86 to
fc8b46a
Compare
bchalios
added
the
Status: Awaiting review
pb8o
previously approved these changes
Aug 29, 2024
resources/guest_configs/patches/0002-ci-adjust-6.1-guest-kernel-configs-for-our-CI.patch
Show resolved
Hide resolved
resources/guest_configs/patches/0002-ci-adjust-6.1-guest-kernel-configs-for-our-CI.patch
Show resolved
Hide resolved
roypat
reviewed
Aug 29, 2024
Manciukic
previously approved these changes
Aug 29, 2024
bchalios
force-pushed
the
make-guest-config-patches
branch
from
fc8b46a to
8f11982
Compare
This reverts commit 6d78999. Previously, we made changes on the guest kernel configs comparing to the AL ones, in order to be able to use these kernels in our CI. In order to be able to track better what changes we are making in our config, we want to keep these changes as patches that we apply when we want to rebuild CI artifacts. Signed-off-by: Babis Chalios <bchalios@amazon.es>
Move the changes we did in 6d78999 in patch and change resources/rebuild.sh to apply all the patches under resources/guest_configs/patches/ before building the kernel. Signed-off-by: Babis Chalios <bchalios@amazon.es>
AL started building 6.1 microVM kernels. Use that Kconfig as our base config for building 6.1 kernels. Also create a patch that adapts it for our CI needs. Signed-off-by: Babis Chalios <bchalios@amazon.es>
bchalios
force-pushed
the
make-guest-config-patches
branch
from
81fbe72 to
f2889ba
Compare
Manciukic
previously approved these changes
Aug 29, 2024
AmazonLinux has backported the patches for 6.1 and we are now building from their tree, so we don't need to manually apply the patches when we re-create CI artifacts. Signed-off-by: Babis Chalios <bchalios@amazon.es>
bchalios
force-pushed
the
make-guest-config-patches
branch
from
f2889ba to
05d6107
Compare
roypat
approved these changes
Aug 30, 2024
Manciukic
approved these changes
Aug 30, 2024
pb8o
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use AmazonLinux tailored guest configs for our 6.1 guest microVM kernels. Also, split the Kconfig for our CI kernels in a base part which will always be reflecting the AmazonLinux config and a set of patches that we apply on top of it before rebuilding our CI kernels. The patches live under
resources/guest_configs/patches/.Reason
AmazonLinux now ships a microVM kernels for 6.1. We want to build with the corresponding Kconfigs and keep track of our CI-specific changes in a form of patches.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.