Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark boottime and memory overhead tests as nonci #4823

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

roypat
Copy link
Contributor

@roypat roypat commented Sep 30, 2024

Changes

These tests do not assert anything, and are only used for us to collect metrics. As such, it suffices to run them once at night (especially because we do not ever actually look at the metrics emitted by the PR runs).

Reason

Save compute resources and reduce CI runtime.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

These tests do not assert anything, and are only used for us to collect
metrics. As such, it suffices to run them once at night (especially
because we do not ever actually look at the metrics emitted by the PR
runs).

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@roypat roypat requested a review from pb8o September 30, 2024 13:07
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.35%. Comparing base (d197394) to head (0956837).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4823   +/-   ##
=======================================
  Coverage   84.35%   84.35%           
=======================================
  Files         249      249           
  Lines       27505    27505           
=======================================
  Hits        23202    23202           
  Misses       4303     4303           
Flag Coverage Δ
5.10-c5n.metal 84.59% <ø> (ø)
5.10-m5n.metal 84.57% <ø> (ø)
5.10-m6a.metal 83.86% <ø> (ø)
5.10-m6g.metal 80.92% <ø> (ø)
5.10-m6i.metal 84.57% <ø> (ø)
5.10-m7g.metal 80.92% <ø> (ø)
6.1-c5n.metal 84.59% <ø> (ø)
6.1-m5n.metal 84.57% <ø> (-0.01%) ⬇️
6.1-m6a.metal 83.86% <ø> (-0.01%) ⬇️
6.1-m6g.metal 80.92% <ø> (ø)
6.1-m6i.metal 84.57% <ø> (+<0.01%) ⬆️
6.1-m7g.metal 80.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Sep 30, 2024
@roypat roypat merged commit 8c7f1dd into firecracker-microvm:main Oct 3, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants