Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net): set tap offload features on restore #4824

Draft
wants to merge 1 commit into
base: firecracker-v1.9
Choose a base branch
from

Conversation

kalyazin
Copy link
Contributor

Changes

TBD

Reason

TBD

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

Set tap offload features on restore.

Signed-off-by: Nikita Kalyazin <kalyazin@amazon.com>
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.33%. Comparing base (d3b02e0) to head (30fae4a).

Files with missing lines Patch % Lines
src/vmm/src/devices/virtio/net/persist.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           firecracker-v1.9    #4824      +/-   ##
====================================================
- Coverage             84.34%   84.33%   -0.02%     
====================================================
  Files                   249      249              
  Lines                 27461    27465       +4     
====================================================
  Hits                  23162    23162              
- Misses                 4299     4303       +4     
Flag Coverage Δ
5.10-c5n.metal 84.55% <20.00%> (-0.02%) ⬇️
5.10-m5n.metal 84.54% <20.00%> (-0.02%) ⬇️
5.10-m6a.metal 83.82% <20.00%> (-0.03%) ⬇️
5.10-m6g.metal 80.90% <20.00%> (-0.02%) ⬇️
5.10-m6i.metal 84.54% <20.00%> (-0.02%) ⬇️
5.10-m7g.metal 80.90% <20.00%> (-0.02%) ⬇️
6.1-c5n.metal 84.55% <20.00%> (-0.02%) ⬇️
6.1-m5n.metal 84.53% <20.00%> (-0.03%) ⬇️
6.1-m6a.metal 83.82% <20.00%> (-0.02%) ⬇️
6.1-m6g.metal 80.90% <20.00%> (-0.02%) ⬇️
6.1-m6i.metal 84.53% <20.00%> (-0.03%) ⬇️
6.1-m7g.metal 80.90% <20.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant