vsock: reuse IoVecBuffer(Mut) buffers for packets within a device #4842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4842 +/- ##
==========================================
+ Coverage 84.35% 84.38% +0.03%
==========================================
Files 249 249
Lines 27505 27494 -11
==========================================
- Hits 23202 23201 -1
+ Misses 4303 4293 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShadowCurse
force-pushed
the
vsock_packet_refactor
branch
2 times, most recently
from
2842692 to
374deae
Compare
roypat
reviewed
Oct 8, 2024
Add rx_packet and tx_packet members to the Vsock type and reuse them for RX and TX processing. This removed overhead of creating new packets for each request. As an additional improvement, we split VsockPacket type into 2 types: VsockPacketRx and VsockPacketTx which allows us to separate logic for RX and TX processing. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
vsock_packet_refactor
branch
2 times, most recently
from
8c55639 to
a71f521
Compare
bchalios
reviewed
Oct 8, 2024
bchalios
changed the title
ShadowCurse
force-pushed
the
vsock_packet_refactor
branch
from
a71f521 to
4ef1fd6
Compare
As we don't create IoVecBuffer(Mut) types at runtime, but reuse existing ones in both virtio-net and virtio-vsock, we don't need to use SmallVec type anymore. With this we remove the type alias. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
vsock_packet_refactor
branch
from
4ef1fd6 to
9720925
Compare
bchalios
approved these changes
Oct 8, 2024
roypat
approved these changes
Oct 8, 2024
roypat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Make
vsockreuse packets for RX and TX paths. This removes overhead of creating packets from the virt queues.This also should prevent regressions from #4799.
Reason
Improved performance.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.