Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial Graviton 4 support #5053

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

ShadowCurse
Copy link
Contributor

Changes

Add ability to detect Graviton 4 (neoverse v2) and adjust host and guest feature checks with new features.

Reason

Graviton 4 on-boarding.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

First step to test m8g is to identify if you run on m8g.

Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Add new set of guest features specific for graviton 4.

Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Add additional Graviton 4 cpu features to the host vs guest test.

Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
@ShadowCurse ShadowCurse marked this pull request as ready for review February 26, 2025 17:05
@ShadowCurse ShadowCurse self-assigned this Feb 26, 2025
@ShadowCurse ShadowCurse added Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Enhancement Indicates new feature requests labels Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.19%. Comparing base (9ff2c7b) to head (f699459).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5053   +/-   ##
=======================================
  Coverage   83.19%   83.19%           
=======================================
  Files         247      247           
  Lines       26641    26641           
=======================================
  Hits        22163    22163           
  Misses       4478     4478           
Flag Coverage Δ
5.10-c5n.metal 83.67% <ø> (+<0.01%) ⬆️
5.10-m5n.metal 83.66% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 82.86% <ø> (+<0.01%) ⬆️
5.10-m6g.metal 79.66% <ø> (ø)
5.10-m6i.metal 83.65% <ø> (-0.01%) ⬇️
5.10-m7g.metal 79.66% <ø> (ø)
6.1-c5n.metal 83.67% <ø> (ø)
6.1-m5n.metal 83.65% <ø> (ø)
6.1-m6a.metal 82.86% <ø> (+<0.01%) ⬆️
6.1-m6g.metal 79.66% <ø> (ø)
6.1-m6i.metal 83.65% <ø> (-0.01%) ⬇️
6.1-m7g.metal 79.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShadowCurse ShadowCurse merged commit dd0bf86 into firecracker-microvm:main Feb 26, 2025
8 of 9 checks passed
@ShadowCurse ShadowCurse deleted the m8g_cpu_features branch February 26, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants