Skip to content

chore: add Graviton4 instances to the bk pipelines #5148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

ShadowCurse
Copy link
Contributor

Changes

Add m8g.metal-24/48xl instances to the instances list used by bk pipelines.

Reason

It is time to test Graviton4 in all pipelines.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

Add m8g.metal-24/48xl instances to the instances
list used by bk pipelines.

Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
@ShadowCurse ShadowCurse self-assigned this Apr 9, 2025
@ShadowCurse ShadowCurse added Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Enhancement Indicates new feature requests labels Apr 9, 2025
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (6338be2) to head (c8bd5b2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5148      +/-   ##
==========================================
+ Coverage   83.04%   83.10%   +0.05%     
==========================================
  Files         250      250              
  Lines       26900    26900              
==========================================
+ Hits        22340    22354      +14     
+ Misses       4560     4546      -14     
Flag Coverage Δ
5.10-c5n.metal 83.59% <ø> (ø)
5.10-m5n.metal 83.59% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 82.81% <ø> (-0.01%) ⬇️
5.10-m6g.metal 79.38% <ø> (ø)
5.10-m6i.metal 83.59% <ø> (+<0.01%) ⬆️
5.10-m7a.metal-48xl 82.80% <ø> (?)
5.10-m7g.metal 79.38% <ø> (ø)
5.10-m7i.metal-24xl 83.54% <ø> (?)
5.10-m7i.metal-48xl 83.55% <ø> (?)
5.10-m8g.metal-24xl 79.38% <ø> (?)
5.10-m8g.metal-48xl 79.38% <ø> (?)
6.1-c5n.metal 83.64% <ø> (+<0.01%) ⬆️
6.1-m5n.metal 83.63% <ø> (ø)
6.1-m6a.metal 82.86% <ø> (ø)
6.1-m6g.metal 79.38% <ø> (ø)
6.1-m6i.metal 83.63% <ø> (+<0.01%) ⬆️
6.1-m7a.metal-48xl 82.85% <ø> (?)
6.1-m7g.metal 79.38% <ø> (ø)
6.1-m7i.metal-24xl 83.64% <ø> (?)
6.1-m7i.metal-48xl 83.65% <ø> (?)
6.1-m8g.metal-24xl 79.38% <ø> (?)
6.1-m8g.metal-48xl 79.38% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roypat roypat enabled auto-merge (rebase) April 10, 2025 09:36
@roypat roypat merged commit 51a324a into firecracker-microvm:main Apr 10, 2025
6 of 7 checks passed
@ShadowCurse ShadowCurse deleted the add_g4 branch April 11, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants