More boot time metrics #5176
Merged
More boot time metrics #5176
+63
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
force-pushed
the
systemd_analyze_boottime
branch
from
cd205f0 to
ea3a06a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5176 +/- ##
==========================================
+ Coverage 82.87% 82.93% +0.05%
==========================================
Files 250 250
Lines 26932 26932
==========================================
+ Hits 22321 22335 +14
+ Misses 4611 4597 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShadowCurse
force-pushed
the
systemd_analyze_boottime
branch
3 times, most recently
from
c8ec305 to
9b806cd
Compare
ShadowCurse
added
the
Status: Awaiting review
roypat
reviewed
Apr 29, 2025
ShadowCurse
force-pushed
the
systemd_analyze_boottime
branch
2 times, most recently
from
a12c403 to
0ef4e46
Compare
ShadowCurse
force-pushed
the
systemd_analyze_boottime
branch
3 times, most recently
from
90b3ef1 to
5a63e50
Compare
roypat
approved these changes
Apr 30, 2025
kalyazin
approved these changes
May 1, 2025
Currently we measure boottime by looking at the Firecracker logs and waiting for the guest to trigger a special boot device inside Firecracker. There is an alternative way of measuring boot time from a guest perspective by using systemd-analyze. Will help us to understand boot times better. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Emit both boot time metrics for boot device: clock time and cpu time. Additionally, stop subtracting VM build time from a guest boot time at the metric emit time. This can be done later at the visualization stage. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Since we already collect this delta, put it into metrics as well. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
This metrics has very small numbers which makes it too volatile for A/B tests. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
systemd_analyze_boottime
branch
from
b438de8 to
266718c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
systemd-analyzeoutput as metrics.Reason
Better boot time test visibility.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.