Skip to content

Update dev-machine-setup.md #5269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arikanev
Copy link

Changes

Added step in readme on enabling autodetect for bridged networking on VMWare.
...

Reason

Necessary for VMware networking functionality to work correctly.
...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • [ X] I have read and understand CONTRIBUTING.md.
  • [ X] I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • [ X] I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • [ X] I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • [ X] I have mentioned all user-facing changes in CHANGELOG.md.
  • [ X] If a specific issue led to this PR, this PR closes the issue.
  • [ X] When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • [ X] I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • [ X] I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@bchalios
Copy link
Contributor

Hi @arikanev,

Could you please fix your commit to pass DCO? You need to add a commit body and commit with git commit -s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants