Enable GitHub Actions #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Let me remove old Go versions due to #61. I can address the issue later. |
kzys
force-pushed
the
github-actions
branch
3 times, most recently
from
d9dd660 to
b2cdc11
Compare
This change enables GitHub Actions and build firectl on various Go versions. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
xibz
reviewed
Feb 18, 2021
| - name: Build | ||
| run: make all | ||
|
|
||
| # GitHub Actions' VMs don't have KVM. Firecracker itself won't work. |
Contributor
There was a problem hiding this comment.
if we are going to use github actions, I would much prefer to host our own github action test instance with kvm to run the tests
Author
There was a problem hiding this comment.
Yeah. GitHub Actions could potentially replace BuildKite altogether. But for now, I'd like to have some here to make sure firectl works on all Go versions.
Contributor
|
I think it's fine to have both github actions (for multiple go versions) and buildkite (for integ tests) like we do in firecracker-containerd. We should create an issue to re-enable go 1.11 once we've found a solution for #61 |
Kern--
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.