Implement versionize for arrays via const generics #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd absolutely love to get rid of the Default + Copy bound as well by using MaybeUninit (this is the stereotypical usecase for it according to the rust docs), but sadly that doesn't seem to be supported with generic T :( rust-lang/rust#61956 |
Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
force-pushed
the
const-generics
branch
from
c39f9ef
to
9023f1a
Compare
Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
force-pushed
the
const-generics
branch
from
9023f1a
to
be69410
Compare
JonathanWoollett-Light
approved these changes
Sep 19, 2023
ShadowCurse
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Roy roypat@amazon.co.uk
Reason for This PR
resolves a TODO. const generics have been stablized since 1.51
Description of Changes
Remove the macro generated impls up to array size 32 with a completely generic version based on const generics
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).unsafecode is properly documented.CHANGELOG.md.