Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flamenco: bpf loader rewrite #1905

Merged
merged 1 commit into from
May 30, 2024
Merged

flamenco: bpf loader rewrite #1905

merged 1 commit into from
May 30, 2024

Conversation

ibhatt-jumptrading
Copy link
Contributor

@ibhatt-jumptrading ibhatt-jumptrading commented May 17, 2024 •
edited
Loading

Rewrite of the bpf loader

ripatel-fd
ripatel-fd previously requested changes May 19, 2024
View reviewed changes
Copy link
Contributor

@ripatel-fd ripatel-fd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

src/flamenco/runtime/program/fd_bpf_loader.c Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader.c Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader.c Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader.c Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader.c Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader.h Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader.h Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader.h Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader.h Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Outdated Show resolved Hide resolved
@ibhatt-jumptrading ibhatt-jumptrading marked this pull request as ready for review May 22, 2024 20:42
@ibhatt-jumptrading ibhatt-jumptrading force-pushed the bpf_loader_rewrite branch 3 times, most recently from d272d5b to c4c560d Compare May 23, 2024 21:17
@topointon-jump topointon-jump removed the request for review from jumpsiegel May 23, 2024 21:20
topointon-jump
topointon-jump reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@topointon-jump topointon-jump left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mid-way through reviewing, will finish by EOD. Feel free to ignore these comments or address in a follow-up PR :)

This is awesome!!

src/flamenco/runtime/fd_pubkey_utils.c Outdated Show resolved Hide resolved
src/flamenco/runtime/fd_pubkey_utils.c Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Show resolved Hide resolved
src/flamenco/runtime/fd_pubkey_utils.c Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Show resolved Hide resolved
topointon-jump
topointon-jump requested changes May 28, 2024
View reviewed changes
Copy link
Contributor

@topointon-jump topointon-jump left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sysvar account checks are consensus-critical, do you mind addressing before merging? 🙏

src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Outdated Show resolved Hide resolved
topointon-jump
topointon-jump requested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@topointon-jump topointon-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! Spotted a few consensus-critical things

src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Outdated Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Show resolved Hide resolved
topointon-jump
topointon-jump requested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@topointon-jump topointon-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few more consensus-critical issues - almost there 😄

topointon-jump
topointon-jump requested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@topointon-jump topointon-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last consensus-critical bug 🎉

src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Show resolved Hide resolved
topointon-jump
topointon-jump requested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@topointon-jump topointon-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round of review! The PDA bug should definitely be fixed before merging 🙏

src/flamenco/runtime/fd_pubkey_utils.c Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Show resolved Hide resolved
src/flamenco/runtime/program/fd_bpf_loader_v3_program.c Show resolved Hide resolved
src/flamenco/runtime/fd_pubkey_utils.c Outdated Show resolved Hide resolved
topointon-jump
topointon-jump previously approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@topointon-jump topointon-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ibhatt-jumptrading ibhatt-jumptrading added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit a165379 May 30, 2024
9 checks passed
@ibhatt-jumptrading ibhatt-jumptrading deleted the bpf_loader_rewrite branch May 30, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripatel-fd ripatel-fd ripatel-fd left review comments

@mjain-jump mjain-jump mjain-jump approved these changes

@topointon-jump topointon-jump topointon-jump left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ibhatt-jumptrading @ripatel-fd @mjain-jump @topointon-jump