-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ballet: add base58 utils #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs Bazel fix for CI builds
@ptaffet-jump Looks like your test takes over 5 minutes to run with coverage enabled FYI.
What do you think? |
@ptaffet-jump CI with code coverage actually timed out after 600s. Would you mind adding that |
If you now run |
b20e806
to
1e797ea
Compare
1e797ea
to
29b521e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismissing my "request changes" review to "neutral".
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
===========================================
+ Coverage 55.13% 91.81% +36.68%
===========================================
Files 179 102 -77
Lines 22707 7942 -14765
Branches 5733 0 -5733
===========================================
- Hits 12519 7292 -5227
+ Misses 6501 650 -5851
+ Partials 3687 0 -3687
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
9dd08f0
to
8f80b0c
Compare
fb974af
to
c424ab4
Compare
and high performance base58->{32,64}B
3b07275
to
5faf8c4
Compare
Add high performance base58 conversion functions (encode and decode) for 32 and 64 bytes. The encoder functions have been especially optimized for AVX.