Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compressible Euler comparison scripts #136

Merged
merged 48 commits into from
Oct 16, 2023
Merged

Compressible Euler comparison scripts #136

merged 48 commits into from
Oct 16, 2023

Conversation

JHopeCollins
Copy link
Collaborator

Scripts for comparing between parallel and serial solutions (i.e. "solution quality") for compressible Euler models

  • Vertical slice model for lee waves over 2D mountain
  • 3D flow model for lee waves over 3D mountain
  • Vertical slice model of density current

@JHopeCollins JHopeCollins added the Examples Example test cases / useage label Sep 26, 2023
@JHopeCollins JHopeCollins self-assigned this Sep 26, 2023
@JHopeCollins
command line arguments and wallclock timing for serial vertical slice…
84f0af9 
… mountain case
@JHopeCollins
command line arguments and wallclock timing for vertical slice mounta…
aef0573 
…in case
@JHopeCollins
command line arguments and wallclock timing for 3D compressible mount…
396cf8c 
…ain case
@JHopeCollins
serial 3D compressible mountain case
5e8a0e3
@JHopeCollins
serial/parallel comparison 3D compressible mountain case
198f52d
@JHopeCollins
clean up vertical slice hydrostatic initialisation solvers asap
b4a86ce
@JHopeCollins
wallclock timing for serial straka vertical slice case
8213361
@JHopeCollins
wallclock timing for straka vertical slice case
f336da0
@JHopeCollins
params update for straka case comparison
fcdade5
@JHopeCollins
Merge branch 'slice_comparison' of https://github.com/firedrakeprojec…
30991d3 
…t/asQ into slice_comparison
@JHopeCollins
flake8
48a35f3
@JHopeCollins
separate compressible 3D scripts from the vertical slice scripts
8f6ac61
@JHopeCollins JHopeCollins marked this pull request as ready for review October 13, 2023 11:55
@JHopeCollins JHopeCollins mentioned this pull request Oct 13, 2023
Merged
colinjcotter
colinjcotter approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@colinjcotter colinjcotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! No issues from me.

@JHopeCollins JHopeCollins merged commit c2a4d0f into master Oct 16, 2023
1 check passed
@JHopeCollins JHopeCollins deleted the slice_comparison branch October 16, 2023 16:07
JHopeCollins added a commit that referenced this pull request Oct 17, 2023
@JHopeCollins
Merge pull request #141 from firedrakeproject/allatonce_subfunctions
e5c8535 
Allatonce subfunctions (waiting on #136)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinjcotter colinjcotter colinjcotter approved these changes

Assignees

@JHopeCollins JHopeCollins

Labels
Examples Example test cases / useage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JHopeCollins @colinjcotter