Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FacetSplitPC #2708

Merged
merged 17 commits into from
Feb 8, 2023
Merged

Add FacetSplitPC #2708

merged 17 commits into from
Feb 8, 2023

Conversation

pbrubeck
Copy link
Contributor

A Python PC that splits a FunctionSpace into cell interior DOFs and facet DOFs.

pefarrell
pefarrell previously approved these changes Jan 19, 2023
Copy link
Member

@JDBetteridge JDBetteridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imports need moving to the top, some comms need to be updated

firedrake/preconditioners/facet_split.py Outdated Show resolved Hide resolved
firedrake/preconditioners/facet_split.py Outdated Show resolved Hide resolved
firedrake/preconditioners/facet_split.py Outdated Show resolved Hide resolved
firedrake/preconditioners/facet_split.py Outdated Show resolved Hide resolved
@dham dham dismissed JDBetteridge’s stale review February 8, 2023 16:42

Apparently done

@dham dham merged commit d84d5d6 into master Feb 8, 2023
@dham dham deleted the pbrubeck/facetsplit branch February 8, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants