Introduce new Constant #2927
Merged
Introduce new Constant #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDBetteridge
force-pushed
the
JDBetteridge/constant_rethink
branch
2 times, most recently
from
4527de5 to
11abb75
Compare
wence-
reviewed
May 15, 2023
JDBetteridge
force-pushed
the
JDBetteridge/constant_rethink
branch
from
d83293a to
73d7f51
Compare
JDBetteridge
changed the title
JDBetteridge
force-pushed
the
JDBetteridge/constant_rethink
branch
from
7d76a71 to
17a81db
Compare
ReubenHill
reviewed
Jun 7, 2023
JDBetteridge
commented
Jun 7, 2023
dham
requested changes
Jun 7, 2023
Co-authored-by: David A. Ham <david.ham@imperial.ac.uk>
JDBetteridge
force-pushed
the
JDBetteridge/constant_rethink
branch
from
1e75ce2 to
485af36
Compare
connorjward
requested changes
Jun 8, 2023
| element = ufl.TensorElement("R", cell, 0, shape=shape) | ||
|
|
||
| R = FunctionSpace(domain, element, name="firedrake.Constant") | ||
| return Function(R, val=dat).assign(value) |
There was a problem hiding this comment.
Same question about value.
There was a problem hiding this comment.
The assign needs to happen for annotation to occur. We can get away with not zeroing the dat, but we need to assign to create an assign block.
Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
dham
reviewed
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is dependent on all of COFFEE being removed first.
Associated Pull Requests:
Fixes Issues:
Checklist for author:
make lintin thefiredrakesource directory).make linkcheck; make html; make latexpdfinfiredrake/docsdirectory)pytest testsin thefiredrakesource directory) (useful, but not essential if you don't have suitable hardware).Checklist for reviewer: