-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pgfplot #2939
add pgfplot #2939
Conversation
|
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
firedrake/pgfplot.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surely this should be part of firedrake.plot
? Perhaps we should make firedrake.plot
a subpackage. If we are careful with namespacing this shouldn't affect an end user at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Yes, we can.
firedrake/pgfplot.py
Outdated
return patches, patch_type | ||
|
||
|
||
def pgfplot(f, filename, degree=1, complex_component='real', print_latex_example=True): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work in parallel? The docstring should probably make it clear either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Updated docstring.
bd25be3
to
1e84261
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. Just wow.
baa6e75
to
f8faef5
Compare
f8faef5
to
a7b97a8
Compare
Description
Enable outputting
Function
data for LaTeX tikz plots. Not for largeFunction
s.Example:
generates an output file "./pgfplot_example_torus_tri.txt" and prints an example usage in LaTeX:
Associated Pull Requests:
Fixes Issues:
Checklist for author:
make lint
in thefiredrake
source directory).make linkcheck; make html; make latexpdf
infiredrake/docs
directory)pytest tests
in thefiredrake
source directory) (useful, but not essential if you don't have suitable hardware).Checklist for reviewer:
Feel free to add reviewers if you know there is someone who is already aware of this work.
Please open this PR initially as a draft and mark as ready for review once CI tests are passing.