Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PC: fix max degree #3401

Merged
merged 3 commits into from
Feb 12, 2024
Merged

PC: fix max degree #3401

merged 3 commits into from
Feb 12, 2024

Conversation

pbrubeck
Copy link
Contributor

Description

@pbrubeck pbrubeck force-pushed the pbrubeck/fix/max-degree branch from 3e017d5 to c187fb6 Compare February 11, 2024 16:22
connorjward
connorjward requested changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing and the changes appear to be straightforward refactoring so I am happy to merge this pending a single style change.

In future please can you provide a description to your PR explaining what you are changing?

firedrake/preconditioners/pmg.py Show resolved Hide resolved
tests/regression/test_fdm.py Outdated Show resolved Hide resolved
@pbrubeck pbrubeck requested a review from connorjward February 12, 2024 18:48
@connorjward connorjward merged commit 63104ed into master Feb 12, 2024
10 checks passed
@connorjward connorjward deleted the pbrubeck/fix/max-degree branch February 12, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjward connorjward connorjward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbrubeck @connorjward