Added in a RestrictedFunctionSpace class #3426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dham
requested changes
Feb 28, 2024
firedrake/bcs.py
Outdated
| @@ -45,6 +46,8 @@ def __init__(self, V, sub_domain): | |||
| (isinstance(V.finat_element, finat.Hermite) and V.mesh().topological_dimension() > 1): | |||
| raise NotImplementedError("Strong BCs not implemented for element %r, use Nitsche-type methods until we figure this out" % V.finat_element) | |||
| self._function_space = V | |||
| if isinstance(sub_domain, (numbers.Integral, str)): | |||
| sub_domain = (sub_domain, ) | |||
firedrake/cython/dmcommon.pyx
Outdated
| # Get boundary points (if the boundary_set exists) and count each type | ||
| constrained_core = 0 | ||
| constrained_owned = 0 | ||
| boundary_points = np.array([]) |
firedrake/cython/dmcommon.pyx
Outdated
| @@ -2331,8 +2427,13 @@ def plex_renumbering(PETSc.DM plex, | |||
| CHKERR(DMLabelHasPoint(labels[l], p, &has_point)) | |||
| if has_point: | |||
| PetscBTSet(seen, p) | |||
| perm[lidx[l]] = p | |||
| lidx[l] += 1 | |||
| if boundary_set and PetscBTLookup(seen_boundary, p) and l <= 1: | |||
There was a problem hiding this comment.
please don't use the variable name l. It's super confusing.
| return node_count*self.value_size | ||
|
|
||
| def local_to_global_map(self, bcs, lgmap=None): | ||
| return lgmap or self.dof_dset.lgmap |
There was a problem hiding this comment.
Let's discuss how much of this can go up to FunctionSpace.
|
This PR #3288 has just been merged. Rebasing will cause conflicts in |
|
It seems the big change in assemble.py has successfully been merged into this branch. The PR on halo_exchange_sf was merged yesterday, so you can drop the commit you cherry picked, and merge |
|
Superseded #3215. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in a RestrictedFunctionSpace class.
This marks boundary nodes in the definition of the FunctionSpace with the goal of removing them from calculations such as in assembly.
This currently only works for FunctionSpace objects, restricted mixed spaces and restrictions based on already defined RestrictedFunctionSpaces are still being worked on elsewhere.
There are tests in tests/regression/test_restricted_function_space.py to check assembly and solve works.
There is also a linked PyOP2 pull request at: https://github.com/OP2/PyOP2/pull/716