Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up things in the ensemble tests #3725

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Fix up things in the ensemble tests #3725

merged 2 commits into from
Sep 26, 2024

Conversation

JDBetteridge
Copy link
Member

Description

  • Parallel assertion

@JDBetteridge JDBetteridge marked this pull request as draft August 5, 2024 19:11
@JDBetteridge JDBetteridge marked this pull request as ready for review September 23, 2024 09:50
JHopeCollins
JHopeCollins requested changes Sep 23, 2024
View reviewed changes
tests/regression/test_ensembleparallelism.py Outdated Show resolved Hide resolved
tests/regression/test_ensembleparallelism.py Outdated Show resolved Hide resolved
tests/regression/test_ensembleparallelism.py Show resolved Hide resolved
@JDBetteridge @JHopeCollins
Apply suggestions from code review
212a37b 
Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk>
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8053 ran6471 passed1582 skipped0 failed

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8059 ran7273 passed786 skipped0 failed

@JHopeCollins JHopeCollins merged commit 5a344e4 into master Sep 26, 2024
12 checks passed
@JHopeCollins JHopeCollins deleted the JDBetteridge/ensemble branch September 26, 2024 12:49
pbrubeck pushed a commit that referenced this pull request Oct 8, 2024
@JDBetteridge @JHopeCollins @pbrubeck
Fix up things in the ensemble tests (#3725)
1c32625 
* Fix parallel assertion

* Apply suggestions from code review

Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk>

---------

Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JHopeCollins JHopeCollins JHopeCollins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JDBetteridge @JHopeCollins