Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for AssembledMatrix #3798

Merged
merged 8 commits into from
Oct 15, 2024
Merged

Conversation

connorjward
Copy link
Contributor

Description

Previously it was not possible to used an AssembledMatrix as the LHS for a solver.

I have hacked around with _arguments to get things to work and I am not completely confident in what I have done. I would appreciate someone familiar with the dual space changes to take a look.

Copy link

github-actions bot commented Oct 14, 2024

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8074 ran7288 passed786 skipped0 failed

Copy link

github-actions bot commented Oct 14, 2024

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8068 ran6487 passed1581 skipped0 failed

firedrake/matrix.py Outdated Show resolved Hide resolved
firedrake/matrix.py Outdated Show resolved Hide resolved
firedrake/matrix.py Outdated Show resolved Hide resolved
tests/regression/test_matrix.py Outdated Show resolved Hide resolved
@connorjward connorjward merged commit 6cc4ff8 into master Oct 15, 2024
12 checks passed
@connorjward connorjward deleted the connorjward/assembled-matrix-fix branch October 15, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants