-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganise "hydrostatic" vertical slice tests #583
Open
tommbendall
wants to merge
14
commits into
main
Choose a base branch
from
TBendall/HydrostaticTests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and move "hydrostatic" tests to case studies
tommbendall
added
bug
Pull requests or issues to relating to something not working
equation
Adding or enhancing a new equation
enhancement
Involves adding a new capability
tidying
Involves tidying up code
good for hackathon
Issues that are good to tackle in a hackathon
example
For adding or updating an example
figure
Relates to or adds a figure
plotting script
Relates to a plotting script
and removed
bug
Pull requests or issues to relating to something not working
equation
Adding or enhancing a new equation
enhancement
Involves adding a new capability
good for hackathon
Issues that are good to tackle in a hackathon
labels
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
example
For adding or updating an example
figure
Relates to or adds a figure
plotting script
Relates to a plotting script
tidying
Involves tidying up code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had always been confused about the "hydrostatic" vertical slice tests, thinking that they were only for use with hydrostatic equation sets.
But reading the Melvin et al 2010 Cartesian ENDGame paper, it's obvious that the test cases can be used with either hydrostatic or non-hydrostatic equation sets. The hydrostatic tests are larger scaler, and so the solutions should be similar between hydrostatic/non-hydrostatic equation sets, whereas the non-hydrostatic tests have a smaller spatial scale and so should show differences.
This PR therefore does some reorganisation and several small related tasks:
hydrostatic
argument, which would turn on the "hydrostatic switch". This means we can run all of these test cases with hydrostatic/non-hydrostatic equation setsspinup_steps
option for the semi-implicit quasi-newton time stepper, which setsalpha
to 1 for a specified number of steps at the beginning of the model, which should help with the initial difficulties over orography