Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise "hydrostatic" vertical slice tests #583

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

tommbendall
Copy link
Contributor

@tommbendall tommbendall commented Dec 9, 2024

I had always been confused about the "hydrostatic" vertical slice tests, thinking that they were only for use with hydrostatic equation sets.

But reading the Melvin et al 2010 Cartesian ENDGame paper, it's obvious that the test cases can be used with either hydrostatic or non-hydrostatic equation sets. The hydrostatic tests are larger scaler, and so the solutions should be similar between hydrostatic/non-hydrostatic equation sets, whereas the non-hydrostatic tests have a smaller spatial scale and so should show differences.

This PR therefore does some reorganisation and several small related tasks:

  1. the Skamarock-Klemp gravity wave tests and the mountain tests are now implemented with a hydrostatic argument, which would turn on the "hydrostatic switch". This means we can run all of these test cases with hydrostatic/non-hydrostatic equation sets
  2. I have updated the final time for the non-hydrostatic gravity wave (I don't know why this was 3600 s, when in the literature it is always 3000 s -- @atb1995 pointed this out to me)
  3. I have tweaked the plotting script for the non-hydrostatic gravity wave so that the wave does not wrap around the periodic boundary
  4. I have moved the mountain test to the case studies repo, in the sister ticket Hydrostatic/Non-hydrostatic Tests gusto_case_studies#34
  5. I have added the Schaer mountain test case so that there is still a mountain test in this repo
  6. I have implemented a spinup_steps option for the semi-implicit quasi-newton time stepper, which sets alpha to 1 for a specified number of steps at the beginning of the model, which should help with the initial difficulties over orography

@tommbendall tommbendall marked this pull request as draft December 9, 2024 10:44
@tommbendall tommbendall added bug Pull requests or issues to relating to something not working equation Adding or enhancing a new equation enhancement Involves adding a new capability tidying Involves tidying up code good for hackathon Issues that are good to tackle in a hackathon example For adding or updating an example figure Relates to or adds a figure plotting script Relates to a plotting script and removed bug Pull requests or issues to relating to something not working equation Adding or enhancing a new equation enhancement Involves adding a new capability good for hackathon Issues that are good to tackle in a hackathon labels Dec 9, 2024
@tommbendall tommbendall marked this pull request as ready for review December 20, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example For adding or updating an example figure Relates to or adds a figure plotting script Relates to a plotting script tidying Involves tidying up code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant