Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests are broken #36

Closed
pogster opened this issue Jun 27, 2018 · 1 comment
Closed

Unit tests are broken #36

pogster opened this issue Jun 27, 2018 · 1 comment

Comments

@pogster
Copy link
Contributor

pogster commented Jun 27, 2018

Because the version number was raised to 1.2.3, the test for 1.2.2 fails (see app/code/community/FireGento/AdminMonitoring/Test/Config/expectations/globalConfig.yaml). (What's the point of such a test anyway?)

FireGento_AdminMonitoring_Test_Config_Config::globalConfig
Failed asserting that 1.2.2 module version is equal to 1.2.2.
--- Expected
+++ Actual
@@ @@
-'1.2.2'
+'1.2.3'

/project/lib/EcomDev/PHPUnit/AbstractConstraint.php:241
/project/lib/EcomDev/PHPUnit/AbstractConstraint.php:226
/project/lib/EcomDev/PHPUnit/Constraint/AbstractConfig.php:76
/project/lib/EcomDev/PHPUnit/Constraint/Config.php:108
/project/app/code/community/EcomDev/PHPUnit/Test/Case/Config.php:210
/project/app/code/community/EcomDev/PHPUnit/Test/Case/Config.php:814
/project/app/code/community/FireGento/AdminMonitoring/Test/Config/Config.php:35
/project/vendor/fiunchinho/phpunit-randomizer/src/PHPUnitRandomizer/TestRunner.php:25
/project/vendor/fiunchinho/phpunit-randomizer/src/PHPUnitRandomizer/Command.php:13
/project/vendor/fiunchinho/phpunit-randomizer/bin/phpunit-randomizer:20
Schrank added a commit that referenced this issue Jun 27, 2018
@pogster
Copy link
Contributor Author

pogster commented Jul 2, 2018

I justed noticed that a follow up test would also be broken...

1) FireGento_AdminMonitoring_Test_Config_Config::globalConfig
Failed asserting that setup resources scheme setup scripts are created in correct version chain order.
--- Expected
+++ Actual
@@ @@
 upgrade-1.2.1-1.2.2.php
-upgrade-1.2.2-1.2.3.php

/project/lib/EcomDev/PHPUnit/AbstractConstraint.php:241
/project/lib/EcomDev/PHPUnit/AbstractConstraint.php:226
/project/lib/EcomDev/PHPUnit/Constraint/AbstractConfig.php:76
/project/lib/EcomDev/PHPUnit/Constraint/Config.php:108
/project/app/code/community/EcomDev/PHPUnit/Test/Case/Config.php:210
/project/app/code/community/EcomDev/PHPUnit/Test/Case/Config.php:379
/project/app/code/community/FireGento/AdminMonitoring/Test/Config/Config.php:39
/project/vendor/fiunchinho/phpunit-randomizer/src/PHPUnitRandomizer/TestRunner.php:25
/project/vendor/fiunchinho/phpunit-randomizer/src/PHPUnitRandomizer/Command.php:13
/project/vendor/fiunchinho/phpunit-randomizer/bin/phpunit-randomizer:20

pogster pushed a commit to gruenspar/firegento-adminmonitoring that referenced this issue Jul 3, 2018
Schrank added a commit that referenced this issue Jun 15, 2020
@Schrank Schrank mentioned this issue Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant