Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shouldAddPriceDetails() to public #210

Closed
Cloudy777 opened this issue Sep 2, 2022 · 2 comments
Closed

shouldAddPriceDetails() to public #210

Cloudy777 opened this issue Sep 2, 2022 · 2 comments

Comments

@Cloudy777
Copy link

Cloudy777 commented Sep 2, 2022 •
edited
Loading

General

  • Module version: v1.1.2

Issue description

Would it be possible to change Plugin/Pricing/AddPriceDetailsPlugin.php::shouldAddPriceDetails() from private to public?
We want to modify when the price details are rendered (some product don't need them).
A plugin here would be the best way imo. We can do a pull request if needed.
What do you think?
@frostblogNet
Copy link
Member

Hello @Cloudy777

there is no reason why this method is private so a pull request would be nice.

Thanks

Cloudy777 pushed a commit to Cloudy777/firegento-magesetup2 that referenced this issue Sep 2, 2022
@SimonCloudy
sets shouldAddPriceDetails method for firegento#210
8c1b2af 
Because:
- allow modification for other modules via plugin
@Cloudy777 Cloudy777 mentioned this issue Sep 2, 2022
Merged
3 tasks
frostblogNet added a commit that referenced this issue Sep 7, 2022
@frostblogNet
Merge pull request #211 from Cloudy777/public-shouldAddPriceDetails-210
b900740 
sets shouldAddPriceDetails method for #210
@frostblogNet
Copy link
Member

Thanks for contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frostblogNet @Cloudy777