Fix attribute group #187
Merged
Fix attribute group #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the unwanted renaming of the attribute group with the
attribute_group_codeproduct-details.To see that, just run a clean M2 installation and check
attribute_group_namein tableeav_attribute_codewhereattribute_group_code=product-details.You will see, that this group is initially called
Product Details.Now add this module and install Magento again. The name will be changed to
General, which is surely not wanted.See
\Magento\Tax\Setup\Patch\Data\AddTaxAttributeAndTaxClassesto see, that Magento itself does it in this way.The renaming of the group leads to critical issues for the Data Migration Module and removes all product attribute values in the M1 General Group completely during the migration.
See magento/data-migration-tool#832 and magento/data-migration-tool#817 for details.