adding in bascis for victorops #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonehusin
reviewed
Apr 2, 2024
go.mod
Outdated
| @@ -72,6 +72,7 @@ require ( | |||
| github.com/russross/blackfriday/v2 v2.1.0 // indirect | |||
| github.com/sahilm/fuzzy v0.1.1-0.20230530133925-c48e322e2a8f // indirect | |||
| github.com/senseyeio/duration v0.0.0-20180430131211-7c2a214ada46 // indirect | |||
| github.com/victorops/go-victorops v1.0.7 // indirect | |||
There was a problem hiding this comment.
interesting... this shouldn't be indirect. might need to run go mod tidy, which reminds me i should add that in CI.
| @@ -20,10 +20,12 @@ type Pager interface { | |||
| PopulateTeamSchedules(ctx context.Context, team *Team) error | |||
| } | |||
|
|
|||
| func NewPager(kind string, apiKey string) (Pager, error) { | |||
| func NewPager(kind string, apiKey string, appId string) (Pager, error) { | |||
pager/victorops.go
Outdated
|
|
||
| func (v *VictorOps) toTeam(team victorops.Team) *Team { | ||
| return &Team{ | ||
| // PagerDuty does not expose a slug, so generate one. |
There was a problem hiding this comment.
Suggested change
| // PagerDuty does not expose a slug, so generate one. | |
| // VictorOps does not expose a slug, so generate one. |
There was a problem hiding this comment.
Added this with my last push
pager/victorops.go
Outdated
| } | ||
|
|
||
| for _, member := range vmembers.Members { | ||
| members = append(members, &User{Resource: Resource{ID: member.Username}}) |
There was a problem hiding this comment.
shouldn't this use toUser as well?
There was a problem hiding this comment.
oh i made the bad example on pagerduty for this one huh woops
wilsonehusin
approved these changes
Apr 2, 2024
wilsonehusin
requested changes
Apr 2, 2024
pager/victorops.go
Outdated
Comment on lines
74
to
83
| vusers, _, err := v.client.GetAllUsers() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| for _, userSlice := range vusers.Users { | ||
| for _, user := range userSlice { | ||
| users = append(users, v.toUser(user)) | ||
| } | ||
| } |
There was a problem hiding this comment.
oops I missed this first time around: probably should use GetAllUserV2 here https://pkg.go.dev/github.com/victorops/go-victorops@v1.0.7/victorops#Client.GetAllUserV2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Victorops init for pulling users and teams