Skip to content

Commit

Permalink
Travis minor update
Browse files Browse the repository at this point in the history
  • Loading branch information
pascalandy committed May 5, 2018
1 parent 7112645 commit 2c6bf35
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 12 deletions.
12 changes: 6 additions & 6 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@ services:
branches:
except:
- tmp99


addons:
apt:
packages:
- docker-ce

# Secret DOCKER_PASSWORD managed by Travis:
# See https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings
#
Expand All @@ -24,11 +29,6 @@ before_install:
- sudo apt-get install -qqy openssl parallel
- docker --version

addons:
apt:
packages:
- docker-ce

install:
- git clone https://github.com/docker-library/official-images.git ~/official-images

Expand Down
13 changes: 7 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ devmtl/ghostfire:edge
I recommand to use the first tag, where:
- `1.22.5-f5f0952` is the **Ghost Version** PLUS the **SHA of the git commit** used to create the build.
- The logic is that I can use a **specific** image to test and push it in PROD as needed. In this example, using `devmtl/ghostfire:1.22.5` could turn out to be a broken docker image and is not best practice.
- **DO NOT** use the **multistage** tags at this point. It is not stable.


## Developper setup

Expand All @@ -91,18 +91,17 @@ Soon, I will share the setup I use on my Mac to develop Ghost Themes and test Gh
- https://github.com/firepress-org/FirePress_Klimax1
- https://github.com/firepress-org/FirePress_Klimax2
- https://github.com/firepress-org/FirePress_Stupendous
- Find everthing I open source around Ghost [here](https://github.com/firepress-org)
- Find everything I open source around Ghost [here](https://github.com/firepress-org)


## Why forking the offical Dockerfile ?

The elements I tweaked are:
I tweaked elements like:

- Ghost container is running under [tini](https://github.com/krallin/tini)
- Using `node:8.11.1-alpine` instead of Node:6
- Cleaner ENV management
- Uninstall the `ghost cli` to safe some space in the docker image
- Eventually, I will use multi-stage builds
- Better ENV var management
- Uninstall the `ghost cli` to safe few bytes in the docker image


## Branches: edge vs master
Expand All @@ -113,6 +112,8 @@ Once I confirm the edge build PASS, I update the Dockerfile under the `master` b

![branch-explanation](https://user-images.githubusercontent.com/6694151/39652598-20980092-4fbc-11e8-9471-84f1cbcb1f4b.jpg)

`multistage` is not working with Travis at this point. Just ignore it exists. Docs https://docs.travis-ci.com/user/build-stages/


## Contributing

Expand Down

0 comments on commit 2c6bf35

Please sign in to comment.