Announce page change using aria-live=assertive #24
Conversation
|
|
||
| const announcerAbout = page.locator('#flamethrower-announcer'); | ||
| await expect(announcerAbout).toHaveText('About'); |
There was a problem hiding this comment.
FYI, there is a tool for validating these announcements. https://www.npmjs.com/package/extend-to-be-announced
Though I'm not sure whether it integrates with playwright nicely.
There was a problem hiding this comment.
Nice, I didn't know about this one. Although, not sure if it is a good idea add a new dev dependency only for this test case 🤔.
Another way of optimizing the test that I was thinking is:
I could use the same variable const announcer = page.locator('#flamethrower-announcer'); for home page and about page as technically is the same node, so maybe it keeps the reference, but I didn't try it and I don't know if it works
|
This looks good, but we've got some conflicts to resolve now. |
|
I am a little bit lost, and first time I am doing this. Not sure what Maybe this: git config pull.rebase false
git pull upstream pull
# Merge conflicts
git commit -m "Merge blah blah blah"
git pushOr what do you guys recommend? |
#18