Firebase v10 #32
Open
Firebase v10 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<a> should be removed from <Link> tags after css has been updated
This integrates the changes of https://github.com/fireship-io/next-firebase-course/pull/4/files
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to update the firebase syntax from v8 to v10 and provide a reference of necessary changes for anyone building the project with @latest packages.
Initially, I tired to only update the minimum dependencies of firebase, react and react-dom, but at the end I ran into one issue with
getUserWithUsernamethrowing an error aboutcollection()not being passed a valid reference even though it was being passedfirestoreand was seemingly working fine in other files. In the end, I decided to just update react/next.js to latest and this resolved the issue.The following changes are made:
existswas being treated as a boolean instead of a function Similar PR<Link>containing<a>errors withlegacyBehavior. CSS might need an update after removing<a>andlegacyBehavior. While writing this PR note, i just realized i blindly added legacyBehavior to all links while getting ready to check in. This is actually only needed on links that contain<a>Note This is my first time using firebase so there might be a better implementation. I've placed a few TODOs with points you might need to consider if using this project as a boilerplate.