Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organized project directory structure #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pratyush0898
Copy link

Improved Project Structure for threejs-scroll-animation-demo

This pull request proposes an improvement to the project's directory structure in the fireship/threejs-scroll-animation-demo repository. The changes aim to enhance code organization and maintainability.

Changes Introduced:

  • public Folder: Created a new folder named public to store static assets that are directly accessible by the browser, such as the favicon.
  • assets Folder: Established a new folder named assets within the src directory to store all application-specific image resources (e.g., jeff.png, moon.jpg, etc.).
  • Updated Paths: Modified any relevant code (likely CSS) to reflect the new location of the image assets within the assets folder.

Benefits:

  • Clearer Organization: Separates code, styles, and assets for better project clarity.
  • Improved Maintainability: Makes it easier to locate and manage project resources.
  • Standardized Structure: Aligns the project structure with common web development practices.

Testing:

This pull request has been tested locally to ensure no functionality is broken due to the directory structure changes.

Pull Request Review:

We kindly request a review of this pull request to incorporate this improved structure into the main fireship/threejs-scroll-animation-demo repository.

Additional Notes:

  • If any manual changes were made to code paths (e.g., CSS), you can mention them here for better context.
  • Feel free to adapt this description to include more specific details about your modifications.

We believe this change will benefit the overall project and would be glad to address any questions or concerns during the review process.

Created a new folder "public" to store static assets like the favicon.
Moved all image assets (jeff.png, moon.jpg, normal.jpg, space.jpg) to a new folder "assets" within "src".
Updated paths to the images in any relevant code (e.g., CSS) to reflect the new location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants