Update README.eg.md #94551
Closed
Update README.eg.md #94551
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git add . git commit -m "fix: replace Slack link with contribution link in Egyptian Arabic Readme" git push origin fix-eg-ar-slack-link
docs/translations/README.eg.md
Outdated
| @@ -138,7 +138,7 @@ git push origin "add-your-name" | |||
| احتفل بأول مساهمة ليك، أعمل شير مع صحابك ومتابعينك عن طريق زيارة <a href="https://firstcontributions.github.io/#social-share">الموقع دة. </a> | |||
| </div> | |||
|
|
|||
| <div dir="rtl">ممكن تنضم للفريق على Slack لو حابب تساعد او عندك أسئلة. <a href="https://join.slack.com/t/firstcontributors/shared_invite/zt-1hg51qkgm-Xc7HxhsiPYNN3ofX2_I8FA"> إنضم للفريق على Slack</a></div> | |||
| <div dir="rtl">ممكن تنضم للفريق على Slack لو حابب تساعد او عندك أسئلة. <a href="https://github.com/firstcontributions/first-contributions"> إنضم للفريق على Slack</a></div> | |||
There was a problem hiding this comment.
The text still says join slack by going to this link.
Also the link is wrong. it should be https://github.com/roshanjossey/code-contributions
There was a problem hiding this comment.
@Roshanjossey The test removed & Link replaced!
| @@ -138,7 +138,13 @@ git push origin "add-your-name" | |||
| احتفل بأول مساهمة ليك، أعمل شير مع صحابك ومتابعينك عن طريق زيارة <a href="https://firstcontributions.github.io/#social-share">الموقع دة. </a> | |||
| </div> | |||
|
|
|||
| <div dir="rtl">ممكن تنضم للفريق على Slack لو حابب تساعد او عندك أسئلة. ></div> | |||
| <div dir="rtl"> | |||
| <a href="https://github.com/roshanjossey/code-contributions">Visit GitHub Repository</a> | |||
There was a problem hiding this comment.
This is in English now. It should be in Arabic in Egyptian Arabic translation right? Also, please check Readme.md for reference
There was a problem hiding this comment.
Resolved, I apologize for issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git add .
git commit -m "fix: replace Slack link with contribution link in Egyptian Arabic Readme" git push origin fix-eg-ar-slack-link
Before submitting this pull request, check the changes to see it's only the changes you made intentionally
If there are changes to other lines you didn't make deliberately, it's possible that your IDE made the changes with a utility like prettier.
Next time, make sure that you only add your changes by using
git add -pand rather thangit add Contributors.mdIf you're doing something in the checklist below, put an
xinside[ ]so that- [ ]becomes- [x]