Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant googlemap settings in wt_module_setting #42

Closed
ddrury opened this issue Nov 23, 2013 · 2 comments
Closed

Redundant googlemap settings in wt_module_setting #42

ddrury opened this issue Nov 23, 2013 · 2 comments

Comments

@ddrury
Copy link
Contributor

ddrury commented Nov 23, 2013

Hi Greg,

Have just noticed this. The following settings (I think) are now unused
GM_API_KEY
GM_DEFAULT_TOP_VALUE
GM_DISP_COUNT
GM_MAX_NOF_LEVELS
GM_PH_CONTROLS
GM_PH_WHEEL
GM_PRE_POST_MODE_1
GM_PRE_POST_MODE_2
GM_PRE_POST_MODE_3
GM_PRE_POST_MODE_4
GM_PRE_POST_MODE_5
GM_PRE_POST_MODE_6
GM_PRE_POST_MODE_7
GM_PRE_POST_MODE_8
GM_PRE_POST_MODE_9

I determined this list by disabling the googlemap module, dumping & then deleting all its settings and then re-enabled it and saved its settings. The above list were all absent.

Dave
@ddrury
Copy link
Contributor Author

ddrury commented Nov 24, 2013

most of these setting were included in db_schema_4_5.php but I don't think the version number in googlemaps/defaultconfig.php was updated

@fisharebest
Copy link
Owner

This cleanup was written during the last major GM changes - but obviously never finished.

fisharebest added a commit that referenced this issue Nov 24, 2013
@fisharebest
Issue #42 - remove old googlemap settings
79736dc
fisharebest added a commit that referenced this issue Dec 2, 2013
@fisharebest
Issue #42 - remove old googlemap settings
1c7b177 
Conflicts:
	modules_v3/googlemap/defaultconfig.php
reenx pushed a commit to reenx/webtrees that referenced this issue Dec 14, 2016
@fisharebest @reenx
Issue fisharebest#42 - remove old googlemap settings
c720704 
Conflicts:
	modules_v3/googlemap/defaultconfig.php
@billyonthemountain billyonthemountain mentioned this issue Apr 29, 2019
Closed
This was referenced May 3, 2019
Closed
Closed
This was referenced May 5, 2019
Closed
Closed
This was referenced May 13, 2019
Closed
Closed
Closed
Closed
@DaPoHou DaPoHou mentioned this issue May 17, 2019
Closed
@Anped Anped mentioned this issue May 18, 2019
Closed
@kexuebin kexuebin mentioned this issue May 20, 2019
Closed
@ricklach ricklach mentioned this issue Jul 11, 2019
Closed
@DaPoHou DaPoHou mentioned this issue Aug 11, 2019
Closed
@makitso makitso mentioned this issue Aug 11, 2019
Closed
@makitso makitso mentioned this issue Aug 28, 2019
Closed
This was referenced Oct 7, 2019
Closed
Closed
@makitso makitso mentioned this issue Oct 14, 2019
Closed
@melizaa melizaa mentioned this issue Oct 16, 2019
Closed
@makitso makitso mentioned this issue Oct 16, 2019
Closed
@ddrury ddrury mentioned this issue Oct 17, 2019
Closed
This was referenced Oct 20, 2019
Closed
Closed
@ramu98 ramu98 mentioned this issue Apr 7, 2020
Closed
@HRN65 HRN65 mentioned this issue Apr 27, 2020
Closed
@GreggShimokura GreggShimokura mentioned this issue May 4, 2020
Closed
This was referenced May 5, 2020
Closed
Closed
@hartenthaler hartenthaler mentioned this issue May 19, 2020
Closed
@ghost ghost mentioned this issue Aug 9, 2020
Closed
@melizaa melizaa mentioned this issue Feb 16, 2021
Closed
@HonkXL HonkXL mentioned this issue Mar 12, 2021
Closed
@makitso makitso mentioned this issue May 4, 2021
Closed
@HRN65 HRN65 mentioned this issue Jul 14, 2021
Closed
@melizaa melizaa mentioned this issue Jul 17, 2021
Closed
@makitso makitso mentioned this issue Sep 15, 2021
Closed
@ThRPctmylSgltwH ThRPctmylSgltwH mentioned this issue Oct 12, 2021
Closed
@makitso makitso mentioned this issue Nov 16, 2021
Closed
@HRN65 HRN65 mentioned this issue Mar 24, 2022
Closed
@FrankWarius FrankWarius mentioned this issue Apr 5, 2022
Closed
@webtrees-pesz webtrees-pesz mentioned this issue Apr 11, 2022
Closed
@melizaa melizaa mentioned this issue Apr 21, 2022
Closed
@FrankWarius FrankWarius mentioned this issue Jun 10, 2022
Closed
@borjian borjian mentioned this issue Jul 19, 2022
Closed
@rookelaar rookelaar mentioned this issue Nov 13, 2022
Open
@gmarcon gmarcon mentioned this issue Jan 8, 2023
Closed
@ddrury ddrury mentioned this issue Jul 12, 2023
Open
@webtrees-pesz webtrees-pesz mentioned this issue Aug 18, 2023
Closed
@makitso makitso mentioned this issue Oct 21, 2023
Closed
@jviseur jviseur mentioned this issue Dec 10, 2023
Closed
@FrankWarius FrankWarius mentioned this issue Dec 31, 2023
Closed
@mpwt mpwt mentioned this issue Dec 21, 2024
Closed
@borjian borjian mentioned this issue Dec 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddrury @fisharebest