Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change family members broken #4674

Closed
ric2016 opened this issue Dec 20, 2022 · 1 comment
Closed

Change family members broken #4674

ric2016 opened this issue Dec 20, 2022 · 1 comment

Comments

@ric2016
Copy link
Contributor

ric2016 commented Dec 20, 2022

Removing any child via ChangeFamilyMembersPage/ChangeFamilyMembersAction results in the family having no children left at all.
Tested on demo server.

Cause: Either the request array is malformed (contains empty entries, i.e. the removed children), example:

[CHIL] => Array
                        (
                            [0] => I6647
                            [1] => I6648
                            [2] => I6649
                            [3] => I6650
                            [4] => I6651
                            [5] => 
                            [6] => I17063
                        )

or it isn't validated corectly here (empty value should probably just be skipped in array, currently the Validator returns null in that case).

@fisharebest
Copy link
Owner

or it isn't validated correctly

The isXref() validator expects an array of valid xrefs - so this is the wrong validation to use here.

ddrury pushed a commit to ddrury/webtrees that referenced this issue Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants