Bug fix #45
Merged
Bug fix #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The "delete" action needs converting from a GET to a POST request. It's probably neatest if we make an AJAX post request to delete the data, and then reload the page. |
Admin theme, when clicking on message "This module cannot be found. Delete its configuration settings." its takes two goes before the display is updated. In addition JustCarmen pointed out that modules don't appear on the admin theme left hand menu when a module is enabled/disabled
fisharebest
added a commit
that referenced
this pull request
Feb 19, 2014
Changes to module status not shown immediately
|
I think this is a case of "perfect being the enemy of the good". Deleting config for old/deleted modules is a sufficiently rare occurrence that there are better things to spend time on... |
This was referenced May 3, 2019
This was referenced May 5, 2019
This was referenced May 13, 2019
Closed
Closed
Closed
This was referenced Oct 7, 2019
This was referenced Oct 20, 2019
Closed
This was referenced May 5, 2020
ghost
mentioned this pull request
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin theme modules page, when clicking on message "This module cannot be found. Delete its configuration settings." its takes two goes before the display is updated.