Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default SVG silhouette icon #5088

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ekdahl
Copy link
Contributor

@ekdahl ekdahl commented Dec 28, 2024

Should not affect supplied themes, until "content" CSS property is unset for parent element. Suggestion for #5049.

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.26%. Comparing base (e636546) to head (3280c67).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5088   +/-   ##
=========================================
  Coverage     35.26%   35.26%           
  Complexity    11413    11413           
=========================================
  Files          1181     1181           
  Lines         47917    47917           
=========================================
  Hits          16900    16900           
  Misses        31017    31017           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fisharebest
Copy link
Owner

I like the idea of using the SVG icons for the silhouette image.

Do you think the "solid" icon is better for this? https://fontawesome.com/icons/user?f=classic&s=solid

We should use the same image in the chart boxes.

Perhaps create a new view (e.g. resources/views/silhouette.phtml) that we can use for both.

I see that the code for thumbnail images / silhouettes is slightly different for chartboxes and the individual page. I need to make this consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants