Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passive Effect Sprites #414

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Conversation

zicklag
Copy link
Member

@zicklag zicklag commented Apr 8, 2022

Depends on #413.

Adds an easy way to add sprites to passive effects.

`impl From<AnimatedSpriteMetadata> for Animated Sprite` and clean
up some of the code that could benefit from it.
@zicklag zicklag force-pushed the passive-effect-sprites branch from 7f0c219 to 23bbbf3 Compare April 8, 2022 18:04
@zicklag
Copy link
Member Author

zicklag commented Apr 8, 2022

Clippy is complaining because adding a sprite field to the passive effect makes it's variant much larger than the other in AnyEffectParams. It suggested boxing PassiveEffectMetadata, is that something we want to do?

@zicklag zicklag force-pushed the passive-effect-sprites branch from 23bbbf3 to ccac77a Compare April 8, 2022 19:51
@orhun
Copy link
Member

orhun commented Apr 10, 2022

Clippy is complaining because adding a sprite field to the passive effect makes it's variant much larger than the other in AnyEffectParams. It suggested boxing PassiveEffectMetadata, is that something we want to do?

Sure, I think it is fine to Box it.

@zicklag zicklag force-pushed the passive-effect-sprites branch from ccac77a to 39f6a34 Compare April 10, 2022 16:25
@olefasting olefasting merged commit 4586de8 into fishfolk:main Apr 12, 2022
@zicklag zicklag deleted the passive-effect-sprites branch April 12, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants