Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "puncy" typos #135

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Fix "puncy" typos #135

merged 1 commit into from
Jul 25, 2022

Conversation

DRuppFv
Copy link
Contributor

@DRuppFv DRuppFv commented Jul 25, 2022

shouldn't it be "punchy"? haha

@64kramsystem
Copy link
Member

He 😄 Thanks for the fix.

Actually, there's another occurrence of the same typo in the codebase, just in case you want to fix all of them. If you do, can you add the other fix to the same commit?

@DRuppFv
Copy link
Contributor Author

DRuppFv commented Jul 25, 2022

He smile Thanks for the fix.

Actually, there's another occurrence of the same typo in the codebase, just in case you want to fix all of them. If you do, can you add the other fix to the same commit?

Are you sure? I didn't find that.

@64kramsystem
Copy link
Member

He smile Thanks for the fix.
Actually, there's another occurrence of the same typo in the codebase, just in case you want to fix all of them. If you do, can you add the other fix to the same commit?

Are you sure? I didn't find that.

There you go!:

src/platform.rs:353:    const BROWSER_LOCAL_STORAGE_KEY: &str = "puncy-platform-storage";

@DRuppFv
Copy link
Contributor Author

DRuppFv commented Jul 25, 2022

He smile Thanks for the fix.
Actually, there's another occurrence of the same typo in the codebase, just in case you want to fix all of them. If you do, can you add the other fix to the same commit?

Are you sure? I didn't find that.

There you go!:

src/platform.rs:353:    const BROWSER_LOCAL_STORAGE_KEY: &str = "puncy-platform-storage";

oh, i saw this, but i thought it was a normal word, not the game name, haha.
done!

@64kramsystem 64kramsystem changed the title fixing typo Fix "puncy" typos Jul 25, 2022
@64kramsystem
Copy link
Member

@DRuppFv can you actually squash the two commits? then, I'll send to PR to the merge pipeline.

@zicklag
Copy link
Member

zicklag commented Jul 25, 2022

Haha, good catch. Those are both my typos. For some reason I have a hard time typing the word punchy and my fingers want to leave out the h.

@64kramsystem
Copy link
Member

bors r+

@64kramsystem
Copy link
Member

Thanks @DRuppFv 😄

@bors bors bot merged commit a3df356 into fishfolk:master Jul 25, 2022
@DRuppFv DRuppFv deleted the fix_config_typo branch July 26, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants