Add more enemies #160
Merged
Add more enemies #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zicklag
requested changes
Jul 27, 2022
Closed
3 tasks
Change Bandit to Brute Co-authored-by: Zicklag <zicklag@katharostech.com>
|
Sweet let's merge it! bors merge |
|
Build succeeded: |
odecay
reviewed
Jul 27, 2022
Comment on lines
35
to
+37
| repeat: false | ||
| attacking: | ||
| frames: [16, 23] | ||
| frames: [14, 16] |
There was a problem hiding this comment.
The frame change in the actual spritesheet asset has broken hitbox despawn for bandit attacks. It will be a simple fix but I won't have time to do it till later today/tonight. Unfortunately 3 frames of animation is really not much to work with, and since I haven't implemented loading attack frame definitions from assets yet all the attacks use the same frame data right now.
edit: it looks like there is at least another frame we can use in the actual spritesheet so it can go up to 4 which gives a bit more space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image property, of the fighter yaml files, now receives an array of image paths that will be loaded and stored.
When adding the correct components for the enemy a random texture atlas is picked.