Fix Bug With Hot Reload and New Loading Progress #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR fishfolk#164 broke hot reloading by accidentally triggering asset update events every time it would check the game load progress. This moves game load progress checking to a system condition instead with a read-only borrow to the game asset to prevent the issue.
zicklag
force-pushed
the
fix-hot-reloading
branch
from
96defe1 to
1dc96f5
Compare
|
Ah, for some reason the condition system is running every frame no matter what and logging loading progress. I'll fix that. |
zicklag
force-pushed
the
fix-hot-reloading
branch
from
1dc96f5 to
4d85333
Compare
|
OK, that should fix it. |
64kramsystem
approved these changes
Jul 29, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #164 broke hot reloading by accidentally triggering asset update
events every time it would check the game load progress.
This moves game load progress checking to a system condition instead
with a read-only borrow to the game asset to prevent the issue.