Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projectile Weapon #258

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Projectile Weapon #258

merged 1 commit into from
Sep 28, 2022

Conversation

Zac8668
Copy link
Collaborator

@Zac8668 Zac8668 commented Sep 24, 2022

Weapon that shoots projectiles.

@Zac8668 Zac8668 marked this pull request as ready for review September 26, 2022 07:56
odecay
odecay reviewed Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@odecay odecay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍
I did a pretty thorough twice over and I didn't notice anything that stuck out negatively. All the gameplay logic certainly looks correct.

@Zac8668
Copy link
Collaborator Author

Zac8668 commented Sep 28, 2022

Not sure if there's anything more that needs to be implemented, maybe @zicklag could take a look

@zicklag
Copy link
Member

zicklag commented Sep 28, 2022

I'll check this out probably within the next few hours. 👍

@Zac8668
Added Projectile Weapon
7bae475 
Added bullet frame spawn and  hitbox offset

Added ammo and shoot delay

No immediate delay

Added bullet frame spawn and  hitbox offset

Added ammo and shoot delay

No immediate delay
zicklag
zicklag approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@zicklag zicklag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this look and works great! 👍

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 28, 2022

Build succeeded:

@bors bors bot merged commit 1e94c18 into fishfolk:master Sep 28, 2022
@Zac8668 Zac8668 deleted the projectile branch September 28, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odecay odecay odecay left review comments

@zicklag zicklag zicklag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zac8668 @zicklag @odecay