Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to bevy 0.9 #288

Merged
merged 3 commits into from
Jan 2, 2023
Merged

upgrade to bevy 0.9 #288

merged 3 commits into from
Jan 2, 2023

Conversation

bayou-brogrammer
Copy link
Contributor

@bayou-brogrammer bayou-brogrammer commented Dec 30, 2022

This is from issue #287

Some wrapper types were needed to make bevy 0.9 resources happy.

Changed:

  • EguiFontDefinitions that wraps egui::FontDefinitions
  • LevelHandle - wraps Handle
  • GameHandle - wraps Handle
  • Bevy rapier upgraded to using Group instead of base u32
  • EguiRenderInputContainer - new wrapper type from bevy_egui for HashMap of keys

src/main.rs Show resolved Hide resolved
@bayou-brogrammer
Copy link
Contributor Author

Added ImagePlugin should be good now

@zicklag
Copy link
Member

zicklag commented Jan 1, 2023

You should be able to cargo update to get the latest version of bevy_mod_js_scripting, that should fix the Wasm CI issue.

Comment on lines +20 to +32
anyhow = "1.0.58"
bevy-parallax = "0.3.0"
bevy_egui = "0.18.0"
bevy_kira_audio = { version = "0.13.0", features = ["mp3"] }
bevy_rapier2d = { version = "0.19.0", features = ["debug-render"] }
egui_extras = "0.20.0"
getrandom = { version = "0.2", features = ["js"] }
iyes_loopless = { version = "0.9.0", features = ["states"] }
rand = "0.8.5"
serde = { version = "1.0.137", features = ["derive"] }
serde_yaml = "0.9.2"
structopt = "0.3.26"
thiserror = "1.0.31"
Copy link
Member

@zicklag zicklag Jan 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, how did you format this file?

I think I kind of like it, if there's an automatic way to do it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh i apologize. that is my vs-code extensions Even Better Toml auto formatting my toml for me. I forget to disable it on other projects since some people hate formatters being run on their code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @odecay doesn't have a problem with it, I'm fine, it's no problem.

I was just curious what you used to format it, because I might want to use it. :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with it for now, if it becomes a problem to maintain formatting without that specific formatter in the future we can always change it back.

@odecay
Copy link
Collaborator

odecay commented Jan 2, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 2, 2023

@bors bors bot merged commit 321a408 into fishfolk:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants