Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make player able to grab Big Bass bomb while fusing #291

Merged
merged 6 commits into from
Jan 14, 2023

Conversation

Zac8668
Copy link
Collaborator

@Zac8668 Zac8668 commented Jan 4, 2023

Closes #280

@Zac8668
Copy link
Collaborator Author

Zac8668 commented Jan 4, 2023

For now I just made the bomb animation fps longer, until we make a bigger animation to extend the time for the player to grab the bomb.

Copy link
Collaborator

@odecay odecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is looking good, will test to make sure everything is working as expected.

assets/items/bomb/bomb.item.yaml Outdated Show resolved Hide resolved
src/fighter_state.rs Show resolved Hide resolved
@odecay
Copy link
Collaborator

odecay commented Jan 12, 2023

Getting panic I think when the boss tries to throw a bomb.

thread 'Compute Task Pool (4)' panicked at 'Fighter has no item', src/fighter_state.rs:1372:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /home/otis/.cargo/registry/src/github.com-1ecc6299db9ec823/bevy_tasks-0.9.1/src/task_pool.rs:273:45

Is there a YAML property that is missing for the boss in this PR?

@odecay
Copy link
Collaborator

odecay commented Jan 14, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 14, 2023

Build succeeded:

@bors bors bot merged commit 6d0fc06 into fishfolk:master Jan 14, 2023
@Zac8668 Zac8668 deleted the grab branch January 14, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make player able to grab Big Bass bomb while fusing
2 participants