Implement Input Mapping #52
Conversation
zicklag
force-pushed
the
input-mapping
branch
2 times, most recently
from
0689660 to
c4f5c87
Compare
zicklag
force-pushed
the
input-mapping
branch
2 times, most recently
from
8f64df8 to
04d2d87
Compare
|
@odecay this is ready for review now. It replaces all game input with mapable actions in three categories: You can also play two players, now, though I believe there's a weird bug where the second player cannot move while the first player is flopping. I haven't investigated yet, but I think we can fix that after this PR. I'm going to follow up with a PR to allow you to navigate the menus with the gamepad, and then after that I'll look into getting two players working without issue. |
Maybe its because of something I did in state checking for that system? Using return instead of break? https://github.com/fishfight/punchy/blob/0060a90bd2fed813a0bf5ae06593ec0b914a5ed1/src/main.rs#L664 |
Awesome! Review + merge will be my first priority after the v0.0.2 release is up today.
👍 Sounds good! |
| - Single: | ||
| GamepadButton: East | ||
|
|
||
| camera: |
There was a problem hiding this comment.
i like the defaults here for camera movement
| @@ -12,6 +12,161 @@ main_menu: | |||
| image: ui/main-menu-background.png | |||
| image_size: [1919, 1027] | |||
|
|
|||
| default_input_maps: | |||
There was a problem hiding this comment.
Very nice how clean it is to have analogs + dpad + keyboard all share input maps
| #TODO turn this into a debug feature | ||
| [patch.crates-io] | ||
| # Patch to enable improved DPad support. It's a merge of the following PR to Bevy 0.7.0 so we can | ||
| # use it before 0.8 is release: https://github.com/bevyengine/bevy/pull/5220. |
There was a problem hiding this comment.
checked out the patch, looks relatively simple lets hope it gets merged 👍
Here's two players controlled both with gamepads, and keyboard controls work too!