-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper camera logic, and new player movement limitations #62
Conversation
bcc0159
to
7ba5b3d
Compare
Ok, this is ready for review etc. Note that this logic has severe limitations. This is intentional; fully implementing the new camera logic requires extensive changes, which IMO should not be applied in a single PR. |
Setting the x value there is not necessary, and it's actually very confusing.
7ba5b3d
to
f166fad
Compare
Addressed all of them. Generalized the forward (right) limit to any number of players. Note that the limitation on the backward (left) behavior is not relative to the rightmost player position, instead, it's based on the boundary. This can make the distance grow more than wanted. This is intended, since the limitation logic will need to be updated along with the new camera logic. |
f166fad
to
c1d57fd
Compare
Extra note: I'm using a feature of the latest stable Rust ( |
This has also the side effect of simplifying the logic :)
Since nobody was looking, I've added the new camera commits 😬 😂 This now fully closes the first task of #29. |
Re-requested review, due to new commits with the new camera logic. |
Closes the first task of #29; the camera has now a proper logic, typical of beat 'em ups.
Boss-related logic is not yet implemented, since there are no bosses yet 😆