Skip to content
This repository has been archived by the owner on Mar 7, 2021. It is now read-only.

Remove explicit list of symbols in build.rs? #30

Open
alex opened this issue May 28, 2018 · 5 comments
Open

Remove explicit list of symbols in build.rs? #30

alex opened this issue May 28, 2018 · 5 comments

Comments

@alex
Copy link
Member

alex commented May 28, 2018

It's a pain to have to constantly update it. Is there a reason not to just bind everything -- other than the compile time penalty (which should theoretically happen less often since we'll be editing build.rs less?)

alex added a commit that referenced this issue May 29, 2018
… symbols

This is less verbose, produces less conflicts, and doesn't really have any major downsides.
@alex
Copy link
Member Author

alex commented May 30, 2018

This cannot be done until rust-lang/rust#51192 is resolved, or const generics land.

@alex
Copy link
Member Author

alex commented Jun 9, 2019

rust-lang/rust#61415 is now the blocker for this.

@alex
Copy link
Member Author

alex commented Aug 9, 2020

Attempted again in #234 -- most of the impls now exist for arrays longer than 32... except Default, which is still limited. (This is slightly messier than other impls, because [T; 0] currently impls Default, even when T does not!)

@damageboy
Copy link

In the absence of this, would be correct to assume that if I want to add some kernel functionality for my driver the correct way is still to update `build.rs? Are you accepting PRs for it etc, or are we in some sort of limbo state?

Could there be, alternatively, an disallow-list for stuff that is knowingly wrong?

You last message on this, and attempt with #234 seems to imply this could be 90% OK-ish, with only small chunks missing, is that the case?

@alex
Copy link
Member Author

alex commented Aug 25, 2020

Yes, adding new bindings is done with a PR to build.rs.

We're definitely still accepting new PRs.

If bindgen has an API to do deny-list instead of allow-list, that'd be fine with me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants