-
Notifications
You must be signed in to change notification settings - Fork 120
Remove explicit list of symbols in build.rs? #30
Comments
… symbols This is less verbose, produces less conflicts, and doesn't really have any major downsides.
This cannot be done until rust-lang/rust#51192 is resolved, or const generics land. |
rust-lang/rust#61415 is now the blocker for this. |
Attempted again in #234 -- most of the impls now exist for arrays longer than 32... except |
In the absence of this, would be correct to assume that if I want to add some kernel functionality for my driver the correct way is still to update `build.rs? Are you accepting PRs for it etc, or are we in some sort of limbo state? Could there be, alternatively, an disallow-list for stuff that is knowingly wrong? You last message on this, and attempt with #234 seems to imply this could be 90% OK-ish, with only small chunks missing, is that the case? |
Yes, adding new bindings is done with a PR to We're definitely still accepting new PRs. If bindgen has an API to do deny-list instead of allow-list, that'd be fine with me. |
It's a pain to have to constantly update it. Is there a reason not to just bind everything -- other than the compile time penalty (which should theoretically happen less often since we'll be editing
build.rs
less?)The text was updated successfully, but these errors were encountered: