Run hello-world through tests

[geofft]

It uses String which none of the others do, and it has its own makefile. We should have coverage for it since it's the user-facing example.

[alex]

Or maybe we should delete it?

…

On Mon, May 6, 2019 at 11:40 AM Geoffrey Thomas ***@***.***> wrote: It uses String which none of the others do, and it has its own makefile. We should have coverage for it since it's the user-facing example. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#83>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAAGBDTYDOZFHLZB65UAALPUBGNBANCNFSM4HLBEMTQ> .

-- All that is necessary for evil to succeed is for good people to do nothing.

[geofft]

I think we should definitely have a copy-and-paste example, including a working kbuild-compatible Makefile. I'm fine with moving it into the tests directory and updating the README, but we should keep the Makefile.

Also hm, example-sysctl doesn't go through CI either, does it? That one seems pretty redundant with the sysctl test.

[alex]

Ok, so let's get hello-world building, add it to tests, and remove example-sysctl

…

On Mon, May 6, 2019 at 12:00 PM Geoffrey Thomas ***@***.***> wrote: I think we should definitely have a copy-and-paste example, including a working kbuild-compatible Makefile. I'm fine with moving it into the tests directory and updating the README, but we should keep the Makefile. Also hm, example-sysctl doesn't go through CI either, does it? That one seems pretty redundant with the sysctl test. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#83 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAAGBGYNWSM6S4TDMEK46LPUBIZPANCNFSM4HLBEMTQ> .

-- All that is necessary for evil to succeed is for good people to do nothing.

[geofft]

Possible approach: let hello-world be the template. If there's a file (mostly Makefile and Cargo.toml) that's in hello-world but not in some other test, it gets a copy of that file with s/hello-world/$test/.

That way hello-world gets to remain a copy-and-paste example but we also don't get duplication of Makefiles etc.

[alex]

I think that's more complexity than is needed -- tests already have a slightly different Makefile. I think the idea outcome would be to make the Makefile parameterized enough that there was only one of them ever.

…

On Mon, May 6, 2019 at 3:36 PM Geoffrey Thomas ***@***.***> wrote: Possible approach: let hello-world be the template. If there's a file (mostly Makefile and Cargo.toml) that's in hello-world but not in some other test, it gets a copy of that file with s/hello-world/$test/. That way hello-world gets to remain a copy-and-paste example but we also don't get duplication of Makefiles etc. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#83 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAAGBDIBHS2Q4DE4CSJIULPUCCC7ANCNFSM4HLBEMTQ> .

-- All that is necessary for evil to succeed is for good people to do nothing.