Skip to content
This repository was archived by the owner on Mar 7, 2021. It is now read-only.

Opaque another type #77

Merged
merged 1 commit into from
Jun 22, 2019
Merged

Opaque another type #77

merged 1 commit into from
Jun 22, 2019

Conversation

alex
Copy link
Member

@alex alex commented Apr 28, 2019

No description provided.

@geofft
Copy link
Collaborator

geofft commented May 6, 2019

@TheDan64 - you have this in a commit in #67 (3cfcb0b) but it doesn't seem to be required and I don't see a version of the kernel where desc_struct is both packed and aligned. It's just packed, and before torvalds/linux@38e9e81 (v4.14) it was a messy union which might be tripping up bindgen.

At the moment we're not building on kernels older than that commit anyway. Should we put this on hold for a bit? Or can we add a comment with exactly what is making bindgen unhappy?

@TheDan64
Copy link
Contributor

TheDan64 commented May 6, 2019

I forget if it was just locally on my machine (4.19), on travis, or both - but I was definitely seeing desc_struct as both packed and aligned.

Edit: But it seems to be only packed in 4.19, so I'm unsure

@geofft
Copy link
Collaborator

geofft commented May 6, 2019

It's possible (though it would be pretty surprising...) that it's a vendor patch in Trusty/Xenial/your machine. Are you checking your own machine's kernel headers or upstream 4.19?

@alex
Copy link
Member Author

alex commented Jun 22, 2019

Ok. I discovered that this was required on a debian stretch kernel. I'd like to land this for that reason.

@reaperhulk reaperhulk merged commit 4464a1d into master Jun 22, 2019
@alex alex deleted the alex-patch-2 branch June 22, 2019 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants