Skip to content
This repository has been archived by the owner on Mar 7, 2021. It is now read-only.

Makefile changes from #67 #84

Closed
wants to merge 4 commits into from
Closed

Makefile changes from #67 #84

wants to merge 4 commits into from

Conversation

geofft
Copy link
Collaborator

@geofft geofft commented May 6, 2019

Convert the Rust .a file into a .o with ld --relocatable, and add a Makefile conditional to separate the user-facing entry points (make all, make clean) from the kbuild bits.

@geofft
Copy link
Collaborator Author

geofft commented May 6, 2019

I don't think either of these changes are required so I'm currently -1 on them for complexity, but I am willing to be convinced otherwise.

@alex
Copy link
Member

alex commented May 6, 2019

I do not understand either makesfile or ld nearly well enough to comment on this, so I defer to you :-)

@geofft
Copy link
Collaborator Author

geofft commented Jul 9, 2019

I'm going to close this for now since it doesn't seem to be required.

@geofft geofft closed this Jul 9, 2019
@alex alex deleted the makefile-changes-from-67 branch December 25, 2019 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants