-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ODBC Server Side Parameters #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jethron! This seems like a clever way of managing a gnarly configuration process. Have you been able to test this locally, to confirm that the configuration supplied in the ODBC string takes effect?
Hey @jtcohen6, I have. With this patch I've successfully used the
I find specifying it here in profiles.yml much neater than the platform-specific instructions for adding it to your ODBC driver configuration, much easier to document for other users of the models. |
That's great to hear, and you named exactly the setting for which I imagined this might prove especially useful. I'm going to update the Changelog on the |
Sorry for the delay, didn't see the edit. Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @jethron!
* Add support for ODBC Server Side Parameters * Update CHANGELOG
* Show more detailed feedback when pyodbc import fails (#192) * Use exception chaining to get more detailed feedback when pyodbc is not installed * Remove pyodbc referenced before assignment * Set back try except * Add flake ignore * Add error message to RunTimeException Error chaining does not show the message in `dbt debug`. Therefore we explicitly add the message to the dbt.exceptions.RunTimeException * Update change log Add to change log that we print the import error when pyodbc can not be imported * Fix parenthesis in change log * Update changelog [skip ci] * Update changelog [skip ci] * Update changelog [skip ci] * Add support for ODBC Server Side Parameters (#201) * Add support for ODBC Server Side Parameters * Update CHANGELOG * Feature/able to retry all connections (#194) * Code changes * README changes * Improve error message default * Changelog * Changelog corrections * Restore accidental deletion * Update dbt/adapters/spark/connections.py Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com> * Add myself to Contributors Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com> * fixed get_columns_in_relation for open source delta table (#207) * fixed get_columns_in_relation for open source delta table * fixed E501 linting error and added change log * fix issue parsing structs (#204) * fix issue parsing structs * include contributor in changelog * better error explanation Co-authored-by: Jeremy Cohen <jeremy@fishtownanalytics.com> * Add adapter unique_field (#211) * Add adapter unique_field * Fix flake8. Add changelog entry * [Snyk] Fix for 2 vulnerabilities (#214) * fix: requirements.txt to reduce vulnerabilities The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-SQLPARSE-1584201 - https://snyk.io/vuln/SNYK-PYTHON-THRIFT-474615 * Removing Thrift conflict with versions over 12 Co-authored-by: leahwicz <60146280+leahwicz@users.noreply.github.com> * 0.21.0b1 Release * Bumping version to 0.21.0b1 * Bumping to 0.21.0b2 * Bumping version to 0.21.0b2 Co-authored-by: Cor <jczuurmond@protonmail.com> Co-authored-by: Jeremy Cohen <jeremy@fishtownanalytics.com> Co-authored-by: Jethro Nederhof <jethro@jethron.id.au> Co-authored-by: gregingenii <80900458+gregingenii@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com> Co-authored-by: Hariharan Banukumar <hariharan.banukumar@gmail.com> Co-authored-by: Sergio <ingscc00@gmail.com> Co-authored-by: Snyk bot <github+bot@snyk.io> Co-authored-by: Ian Knox <ian.knox@fishtownanalytics.com> Co-authored-by: Leah Antkiewicz <leah.antkiewicz@dbtlabs.com>
Description
Allow passing through Cluster Configuration parameters via
profiles.yml
when using theodbc
connection method.This allows configuration of values that would need to be set via SET to be run in the Spark session and take effect on DBT models.
E.g.:
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.