Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor rendering bug for clickable docs serve output #2027

Closed
5 tasks
aaronsteers opened this issue Jan 2, 2020 · 6 comments · Fixed by #2131
Closed
5 tasks

Minor rendering bug for clickable docs serve output #2027

aaronsteers opened this issue Jan 2, 2020 · 6 comments · Fixed by #2131
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors!

Comments

@aaronsteers
Copy link
Contributor

Describe the bug

When running dbt serve the printout of the url where the docs are served is rendering with a period ('.') immediately adjacent to the link. This is a minor issue but it prevents link detection from working correctly by terminals (VS Code in my case) which automatically detect URLs and render them as hyperlinks. In this case, the output is correctly parsed as a URL but because the URL includes a '.' at the end, it reaches a dead end (equivalent to pasting http://localhost:8081. in chrome address bar).

To access from your browser, navigate to http://localhost:8080.

Steps To Reproduce

  1. Run dbt docs serve

Expected behavior

Ideally, the printout would be rendered as:

To access from your browser, navigate to: http://localhost:8080

Screenshots and log output

Running with dbt=0.13.0
Serving docs at 0.0.0.0:8080
To access from your browser, navigate to http://localhost:8080.
Press Ctrl+C to exit.

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake
  • other (specify: ____________)

The output of dbt --version:

Running with dbt=0.13.0

The operating system you're using:

The output of python --version:

Additional context

Add any other context about the problem here.

@aaronsteers aaronsteers added bug Something isn't working triage labels Jan 2, 2020
aaronsteers added a commit to aaronsteers/dbt that referenced this issue Jan 2, 2020
@aaronsteers
Copy link
Contributor Author

PR created here: aaronsteers#1

@drewbanin drewbanin added good_first_issue Straightforward + self-contained changes, good for new contributors! and removed triage labels Jan 5, 2020
@drewbanin drewbanin added this to the Barbara Gittings milestone Jan 5, 2020
@drewbanin
Copy link
Contributor

drewbanin commented Jan 5, 2020

Thanks @aaronsteers - I buy this!

Can you open the PR you made against this repo? If you set the base branch to dev/barbara-gittings, then I'd be happy to merge it post-haste :)

@aaronsteers
Copy link
Contributor Author

Happy to! I'll rebase against that branch (dev/barbara-gittings), reopen the PR in this repo, and send this over.

@drewbanin
Copy link
Contributor

hey @aaronsteers - are you still able to open up that PR against this repo? Would be good to get this fix merged for v0.16.0!

@aaronsteers
Copy link
Contributor Author

@drewbanin - Yes - sorry to delay this. I'll try to get this done today against dev/barbara-gittings - unless I should use a different target (just lmk).

@aaronsteers
Copy link
Contributor Author

Closed and replaced with #2131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants