Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include_policy vs. quote_policy in BigQueryRelation #2188

Closed
1 of 5 tasks
jwills opened this issue Mar 6, 2020 · 2 comments · Fixed by #2325
Closed
1 of 5 tasks

include_policy vs. quote_policy in BigQueryRelation #2188

jwills opened this issue Mar 6, 2020 · 2 comments · Fixed by #2325
Labels
bigquery bug Something isn't working

Comments

@jwills
Copy link
Contributor

jwills commented Mar 6, 2020

Describe the bug

It looks like there's a (possibly innocuous?) bug in the impl of get_include_policy inside of BigQueryRelation, where it's returning a cloned Policy based on the relation.quote_policy, instead of relation.include_policy.

Steps To Reproduce

It would only occur if the quote policy was different from the include policy- perhaps that doesn't happen for BQ?

Expected behavior

The modified include_policy should be based on the relation's include_policy, not it's quote_policy.

Screenshots and log output

If applicable, add screenshots or log output to help explain your problem.

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake
  • other (specify: ____________)

Additional context

Add any other context about the problem here.

@jwills jwills added bug Something isn't working triage labels Mar 6, 2020
@jwills
Copy link
Contributor Author

jwills commented Mar 6, 2020

@drewbanin drewbanin removed the triage label Mar 17, 2020
@drewbanin
Copy link
Contributor

Thanks @jwills - this is definitely a bug - we'll fix this in the next dbt release :)

@drewbanin drewbanin added this to the Octavius Catto milestone Mar 18, 2020
beckjake pushed a commit that referenced this issue Apr 14, 2020
The BigQuery information schema previously used its quote policy as the basis
for a new include policy, rather than its include policy.
beckjake pushed a commit that referenced this issue Apr 14, 2020
The BigQuery information schema previously used its quote policy as the basis
for a new include policy, rather than its include policy.
beckjake added a commit that referenced this issue Apr 15, 2020
…-vs-quote-policy

Fix include_policy vs. quote_policy bug in BigQueryRelation (#2188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants